Skip to content

fix(nextjs): Pass request in sampling context of data fetchers wrapper transaction#5730

Merged
lobsterkatie merged 1 commit intokmclb-nextjs-use-requestdata-integration-for-errorsfrom
kmclb-nextjs-add-sampling-context-in-data-fetcher-wapper
Sep 21, 2022
Merged

fix(nextjs): Pass request in sampling context of data fetchers wrapper transaction#5730
lobsterkatie merged 1 commit intokmclb-nextjs-use-requestdata-integration-for-errorsfrom
kmclb-nextjs-add-sampling-context-in-data-fetcher-wapper

Conversation

@lobsterkatie
Copy link
Copy Markdown
Member

@lobsterkatie lobsterkatie commented Sep 13, 2022

This adds the request to the sampling context passed to the startTransaction call in the data fetchers wrapper in nextjs, to bring it in line with the startTransaction calls elsewhere in the SDK.

@vladanpaunovic
Copy link
Copy Markdown
Contributor

IGNORE ME FOR NOW

ok

@lobsterkatie lobsterkatie force-pushed the kmclb-nextjs-add-sampling-context-in-data-fetcher-wapper branch from b0e42b9 to 0093c9c Compare September 19, 2022 07:57
@lobsterkatie lobsterkatie force-pushed the kmclb-nextjs-add-sampling-context-in-data-fetcher-wapper branch from 0093c9c to ab6d376 Compare September 20, 2022 22:01
@lobsterkatie lobsterkatie changed the base branch from master to kmclb-nextjs-use-requestdata-integration-for-errors September 20, 2022 23:34
@lobsterkatie lobsterkatie marked this pull request as ready for review September 20, 2022 23:35
@lobsterkatie lobsterkatie merged commit a780472 into kmclb-nextjs-use-requestdata-integration-for-errors Sep 21, 2022
@lobsterkatie lobsterkatie deleted the kmclb-nextjs-add-sampling-context-in-data-fetcher-wapper branch September 21, 2022 00:16
@lobsterkatie lobsterkatie restored the kmclb-nextjs-add-sampling-context-in-data-fetcher-wapper branch September 21, 2022 00:16
@lobsterkatie
Copy link
Copy Markdown
Member Author

Dammit. Merged into the wrong branch. 🤦🏻‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants