chore(nextjs): Remove obsolete dataFetchers loader#5713
Merged
lobsterkatie merged 3 commits intomasterfrom Sep 9, 2022
Merged
Conversation
40db6c3 to
2a85b61
Compare
AbhiPrasad
approved these changes
Sep 9, 2022
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
rip jscodeshift dreams - maybe one day
Member
Author
Oh, man, I know. All that AST stuff was hard work, LOL! Makes me sad to rip it all out so soon (even though I fully agree that its replacement is better). Ah, well... |
2a85b61 to
74dde35
Compare
Contributor
size-limit report 📦
|
This was referenced Sep 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
dataFetchersloader and its associated files and dependencies, now that it's been supplanted by the proxy loader. It also changes the build config slightly - somehow, the presence of everything this PR deletes made it so the loaders files output themselves where we want them, even without theentryFileNamessetting they ought to have needed. Alas, doing the deletions broke the spell, and now they won't build to the right place withoutentryFileNames, so this adds it. (Even though we've now reverted to what logically should be true, I'm still baffled, because what on earth was happening before?)Note: Until we fully settle the CJS questions, I'm leaving
isESM.tsin the SDK, even though after this change it will be (for the moment) unused.Ref: #5505