fix(nextjs): Remove sentry property from returned next config#5456
Closed
mitchheddles wants to merge 1 commit intogetsentry:masterfrom
Closed
fix(nextjs): Remove sentry property from returned next config#5456mitchheddles wants to merge 1 commit intogetsentry:masterfrom
mitchheddles wants to merge 1 commit intogetsentry:masterfrom
Conversation
3 tasks
Member
|
Hi, @mitchheddles. Thanks for the contribution! This is a good idea, but you'll see that some of your tests are failing. This is because of a timing issue, even though I see that you moved The fix is to grab it and store it in a closure around the returned function. I tried to make those changes in this PR, but got an auth error when I tried to push. I've therefore created a new PR combining your original idea and the fix: #5473. Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next recently added config validation vercel/next.js#38498 so
withSentryConfigshould remove the additionalsentryproperty to avoid these warnings.Fixes #5449
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).