feat(tracing): Record transaction name source when name set directly#5396
Merged
lobsterkatie merged 7 commits intomasterfrom Jul 8, 2022
Merged
Conversation
Contributor
size-limit report 📦
|
AbhiPrasad
approved these changes
Jul 8, 2022
Merged
32e90dd to
a478689
Compare
898dd30 to
f5a8337
Compare
15 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds transaction name source to transaction metadata in various situations in which the name is set directly: starting a manual transaction, assigning to the
nameproperty of a transaction, calling a transaction'ssetNamemethod, and changing the name usingbeforeNavigate.In order to distinguish manually-created transactions from automatically-created ones, all internal uses of
startTransactionhave been changed so that they are happening directly on the hub, rather than through the top-levelSentry.startTransaction()wrapper.