fix(remix): Wrap handleDocumentRequest functions.#5387
Merged
AbhiPrasad merged 2 commits intomasterfrom Jul 8, 2022
Merged
Conversation
Contributor
|
I think we can also try wrapping resource requests. I will update the main tracking GH issue accordingly. will review in a bit! |
AbhiPrasad
reviewed
Jul 8, 2022
e765a59 to
b3ad7ea
Compare
AbhiPrasad
approved these changes
Jul 8, 2022
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
b3ad7ea to
9ee8190
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #5362
We're currently wrapping
actionandloaderfunctions of Remix routes for tracing and error capturing.When testing the case in #5362, I realized the
renderfunction of a SSR component in Remix has another handlerhandleDocumentRequestwhich doesn't re-throw internal errors so we can't catch them inwrapRequestHandler.Also added a tracing span for
handleDocumentRequest.Note: This is also the case with👇resourcerequests. Maybe we need to wrap them as well?handleResourceRequestis not passed as a parameter tocreateRequestHandler(that's how we currently access the handlers to wrap). It also only runsactionorloaderfunctions, which are already instrumented. So the errors are captured onaction/loaderlevel.