feat(sdk): Add sendDefaultPii option to the JS SDKs#5341
Merged
Conversation
So far, just the option and a method to query it, similarly to how the Python SDK does it
Contributor
size-limit report 📦
|
lforst
approved these changes
Jun 30, 2022
Lms24
commented
Jun 30, 2022
Comment on lines
+446
to
+450
| public shouldSendDefaultPii(): boolean { | ||
| const { client } = this.getStackTop(); | ||
| const options = client && client.getOptions(); | ||
| return Boolean(options && options.sendDefaultPii); | ||
| } |
Member
Author
There was a problem hiding this comment.
For future readers and reviewers: This is similar to how the Python SDK is doing it
AbhiPrasad
approved these changes
Jun 30, 2022
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
sendDefaultPiioption to the JS SDKs. It doesn't yet do anything for the reasons addressed in #5340. In a follow-up PR, we'll make sending the user id in the dynamic sampling context dependent on this flag. (Decided to do this in two PRs to keep DSC changes (+ test adjustments) separate from the introduction of this flag.resolves #5340