fix(build): Add missing debug logger plugin in debug.min bundle variant config#5192
Merged
lobsterkatie merged 1 commit intomasterfrom Jun 2, 2022
Merged
Conversation
Contributor
size-limit report 📦
|
AbhiPrasad
approved these changes
Jun 2, 2022
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
Can we somehow regression test this so it doesn’t accidently happen again in the future?
Member
Author
I think this falls under the same heading as testing all the code we use to muck with webpack config in the nextjs SDK - we say to do_____, but what does the eventual bundle look like? And yes, it would be great to get that working. I will make an issue to track it. (Update: done. #5195) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores the plugin which includes debug logging in the configuration for our
.debug.minbundles. (It was accidentally dropped in #5142.)