Closed
Conversation
Lms24
reviewed
May 5, 2022
Member
There was a problem hiding this comment.
I think it's a good change to have this extra package. I left some questions/comments but they shouldn't block for now, given that the package itself is still empty. Seems like building the package fails in CI though. I think if we fix CI, this is good to go from my perspective.
Lms24
reviewed
May 5, 2022
Lms24
reviewed
May 5, 2022
655d05d to
b7e8f57
Compare
Contributor
size-limit report 📦
|
abd939a to
7343ecf
Compare
Lms24
approved these changes
May 6, 2022
7343ecf to
29e3da8
Compare
29e3da8 to
5d67d78
Compare
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Contributor
|
This is a great idea we should pursue later on, but for now closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we're not using it immediately, I'm going to wait to merge this until a few other structural changes have gone through. Moving back to draft.
This adds the skeleton of a new
dev-utilspackage, which will eventually hold a lot of the stuff that's started to litter the top level of our repo (rollup helpers, jest transformers, etc), as well as give us a place to put, for example, testing helpers which right now have to be copied across packages.Work to move things into the package (and update anything that points to the old locations) will happen in follow-up PRs.
Note: There is a little cruft here, of the kind from which all of our packages suffer, which I left alone (for the moment) for simplicity's sake. When we do the work to clean up this junk repo-wide, these crufty areas will get taken care of.