fix: Update span op for outgoing HTTP requests#3821
Conversation
We've established that incoming requests have op=http.server and outgoing requests have op=http.client. Specification available at: https://develop.sentry.dev/sdk/features/#http-client-integrations Last update: getsentry/develop#341
AbhiPrasad
left a comment
There was a problem hiding this comment.
This will have product ramifications. Pinging @getsentry/visibility to get their thoughts.
size-limit report
|
|
Nice, our tests caught something :D |
Haha, yeah, it was a |
Do you mean operations breakdown? Ops breakdown uses |
|
@k-fish @rhcarvalho @AbhiPrasad tldr: this has no product ramifications; this rename will match cleanly on the operation names breakdown feature. In other words, |
AbhiPrasad
left a comment
There was a problem hiding this comment.
Perfect, think we are good to go then.
We've established that incoming requests have
op=http.serverand outgoing requests haveop=http.client.Specification available at: https://develop.sentry.dev/sdk/features/#http-client-integrations
Last update: getsentry/develop#341
Note: this has the unfortunate potential to break anything relying on the old
opvalue. While the change is simple, some consideration needs to be taken.