Skip to content

[@sentry/tracing] Express route tracing#2972

Merged
kamilogorek merged 6 commits intogetsentry:masterfrom
xr0master:tracing/add-route-method-tracing
Oct 19, 2020
Merged

[@sentry/tracing] Express route tracing#2972
kamilogorek merged 6 commits intogetsentry:masterfrom
xr0master:tracing/add-route-method-tracing

Conversation

@xr0master
Copy link
Contributor

@xr0master xr0master commented Oct 13, 2020

Should add the ability to track express routes. What methods to track is set through options.
By default, methods are ignored.

Example:

  integrations: [
    // enable HTTP calls tracing
    new Sentry.Integrations.Http({ tracing: true }),
    // enable Express.js middleware tracing
    new Tracing.Integrations.Express({ app, methods: ['get', 'post'] }),
  ],
  tracesSampleRate: 1.0,

This PR is relevant to: #2968

@kamilogorek
Copy link
Contributor

kamilogorek commented Oct 16, 2020 •
edited
Loading

Thanks for the PR, looks good! However, I think it should be possible to reuse the very same function for all possible router methods.

@xr0master
Copy link
Contributor Author

xr0master commented Oct 17, 2020

the use function is not a router method, so I hesitated to add it or not... I left it aside.
But I agree that it is possible to rewrite the code a bit to use the same logic.

@xr0master
Copy link
Contributor Author

xr0master commented Oct 17, 2020

With a new commit, the same logic was used.
use method has remained on the sidelines for now, it's easier to separate it from route methods. But if there is a goal to reduce the size, then we can use one function and inject the use method in the constructor.

@xr0master
Copy link
Contributor Author

xr0master commented Oct 17, 2020

Or use can work exactly like a route method, but then there is a chance that developers will forget to add this method or methods and Performance will be empty. But may be nothing wrong here.

@kamilogorek kamilogorek merged commit 57eaded into getsentry:master Oct 19, 2020
@kamilogorek
Copy link
Contributor

kamilogorek commented Oct 19, 2020

Thanks! :)

@kamilogorek kamilogorek mentioned this pull request Oct 19, 2020
Closed
@xr0master xr0master deleted the tracing/add-route-method-tracing branch October 19, 2020 10:30
@Pierre-Demessence Pierre-Demessence mentioned this pull request Jan 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xr0master @kamilogorek