Skip to content

feat(browser): Export getTraceData from the browser sdks#16433

Merged
AbhiPrasad merged 2 commits intodevelopfrom
abhi-getTraceData-browser
May 30, 2025
Merged

feat(browser): Export getTraceData from the browser sdks#16433
AbhiPrasad merged 2 commits intodevelopfrom
abhi-getTraceData-browser

Conversation

@AbhiPrasad
Copy link
Copy Markdown
Contributor

@AbhiPrasad AbhiPrasad commented May 30, 2025

resolves #16418

@AbhiPrasad AbhiPrasad requested a review from a team May 30, 2025 13:19
@AbhiPrasad AbhiPrasad self-assigned this May 30, 2025
@AbhiPrasad AbhiPrasad requested review from Lms24 and andreiborza and removed request for a team May 30, 2025 13:19
@AbhiPrasad AbhiPrasad mentioned this pull request May 30, 2025
Closed
3 tasks
Lms24
Lms24 reviewed May 30, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move this to exports.ts rather than index? Given we export stuff like ?continueTrace from CDN bundles, I think we should also export this one in the bundles

@AbhiPrasad
Copy link
Copy Markdown
Contributor Author

AbhiPrasad commented May 30, 2025

Yeah good point! I moved to exports.ts in 5832141

Lms24
Lms24 approved these changes May 30, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) May 30, 2025 13:32
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 30, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.99 kB - -
@sentry/browser - with treeshaking flags 23.76 kB - -
@sentry/browser (incl. Tracing) 38.29 kB - -
@sentry/browser (incl. Tracing, Replay) 76.43 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 69.55 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 81.19 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 93.27 kB - -
@sentry/browser (incl. Feedback) 40.73 kB - -
@sentry/browser (incl. sendFeedback) 28.7 kB - -
@sentry/browser (incl. FeedbackAsync) 33.59 kB - -
@sentry/react 25.76 kB - -
@sentry/react (incl. Tracing) 40.29 kB - -
@sentry/vue 28.34 kB - -
@sentry/vue (incl. Tracing) 40.13 kB - -
@sentry/svelte 24.01 kB - -
CDN Bundle 25.48 kB +0.7% +175 B 🔺
CDN Bundle (incl. Tracing) 38.48 kB +0.03% +9 B 🔺
CDN Bundle (incl. Tracing, Replay) 74.33 kB +0.02% +8 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 79.75 kB +0.02% +8 B 🔺
CDN Bundle - uncompressed 74.41 kB +0.7% +512 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 113.89 kB +0.02% +18 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 227.86 kB +0.01% +18 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 240.69 kB +0.01% +18 B 🔺
@sentry/nextjs (client) 41.96 kB - -
@sentry/sveltekit (client) 38.79 kB - -
@sentry/node 149.87 kB +0.01% +1 B 🔺
@sentry/node - without tracing 98.13 kB +0.01% +1 B 🔺
@sentry/aws-serverless 123.88 kB - -

View base workflow run

@AbhiPrasad AbhiPrasad merged commit bf3b102 into develop May 30, 2025
124 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-getTraceData-browser branch May 30, 2025 13:46
@nbbeeken
Copy link
Copy Markdown

nbbeeken commented Jun 2, 2025

Happy Monday, thanks @AbhiPrasad for the quick turnaround here, is it possible this could be published soon? TIA! appreciate the help 🙂

@AbhiPrasad
Copy link
Copy Markdown
Contributor Author

AbhiPrasad commented Jun 2, 2025

Hey @nbbeeken - we'll get a release cut today! There's some other folks waiting on this as well.

To unblock yourself, you can import getTraceData from @sentry/core. The core package is what all of our SDKs depend on under the hood (browser, node, edge, etc.)

This was referenced Sep 29, 2025
Closed
Closed
This was referenced Oct 7, 2025
Closed
Closed
This was referenced Oct 15, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

@andreiborza andreiborza Awaiting requested review from andreiborza andreiborza was automatically assigned from getsentry/team-javascript-sdks

Assignees

@AbhiPrasad AbhiPrasad

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sentry.getTraceData is not exported from @sentry/react

3 participants

@AbhiPrasad @nbbeeken @Lms24