feat(react-router): Create low quality transactions filter for react router#16219
Merged
RulaKhaled merged 8 commits intodevelopfrom May 12, 2025
Merged
Conversation
AbhiPrasad
reviewed
May 7, 2025
mydea
reviewed
May 8, 2025
packages/react-router/src/server/lowQualityTransactionsFilterIntegration.ts
Outdated
Show resolved
Hide resolved
mydea
approved these changes
May 8, 2025
Member
mydea
left a comment
There was a problem hiding this comment.
nice work!
Not sure, something to look at in a follow up, but does the logic we have for nuxt make sense where we ignore all requests to files with ending (e.g. GET asdasd.png)? 🤔 but this is something to iterate on :)
Member
@mydea good point but we need to make sure not to filter e.g. /some/route.data as we depend on that atm 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter out server side noisy transactions triggered by http integration from react-router. Fixes: #16161