Conversation
added 4 commits
January 9, 2025 11:06
…-sampler-for-all-root-spans
lforst
commented
Jan 9, 2025
Comment on lines
+127
to
134
| if ( | ||
| !sampled && | ||
| // We check for `parentSampled === undefined` because we only want to record client reports for spans that are trace roots (ie. when there was incoming trace) | ||
| parentSampled === undefined | ||
| ) { | ||
| DEBUG_BUILD && logger.log('[Tracing] Discarding root span because its trace was not chosen to be sampled.'); | ||
| this._client.recordDroppedEvent('sample_rate', 'transaction'); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
@mydea would you mind checking, is this still correct?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are changing the behavior for
tracesSamplerso that it is no longer passed every span, but only root spans. We do this to ensure and steer users towards making consistent and deterministic sampling decisions for traces.This is needed as a first step for #14932