Skip to content

feat(nextjs)!: Don't rely on Next.js Build ID for release names#14939

Merged
lforst merged 4 commits intodevelopfrom
lforst-dont-rely-on-buildid
Jan 9, 2025
Merged

feat(nextjs)!: Don't rely on Next.js Build ID for release names#14939
lforst merged 4 commits intodevelopfrom
lforst-dont-rely-on-buildid

Conversation

@lforst
Copy link
Copy Markdown
Contributor

@lforst lforst commented Jan 8, 2025

Resolves #14940

@lforst lforst marked this pull request as ready for review January 8, 2025 13:16
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 8, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
84 1 83 8
View the full list of 1 ❄️ flaky tests
client-app-routing-instrumentation.test.ts Creates a navigation transaction for app router routes

Flake rate in main: 10.71% (Passed 25 times, Failed 3 times)

Stack Traces | 30s run time
client-app-routing-instrumentation.test.ts:19:5 Creates a navigation transaction for app router routes

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@lforst lforst requested a review from chargome January 8, 2025 14:35
Copy link
Copy Markdown
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

## `@sentry/nextjs`

- Deprecated `hideSourceMaps`. No replacements. The SDK emits hidden sourcemaps by default.
-
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to add anything here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh whoops

@lforst lforst merged commit 550288e into develop Jan 9, 2025
@lforst lforst deleted the lforst-dont-rely-on-buildid branch January 9, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v9] Don't rely on Next.js Build ID for release names

2 participants