fix(react): align Error Boundary componentStack typing with React.Err…#14327
Closed
kunal-511 wants to merge 1 commit intogetsentry:developfrom
kunal-511:fix-#14310
Closed
fix(react): align Error Boundary componentStack typing with React.Err…#14327kunal-511 wants to merge 1 commit intogetsentry:developfrom kunal-511:fix-#14310
kunal-511 wants to merge 1 commit intogetsentry:developfrom
kunal-511:fix-#14310
Conversation
AbhiPrasad
reviewed
Nov 28, 2024
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
Hey, thanks for opening a PR!
This also involves changing ErrorBoundaryState as well as onReset lifecycle methods, which makes this a breaking change.
Let's revisit this when we start working on v9!
Contributor
|
I've opened #14742 for this change, so closing this PR. Thanks for contributing though - I've left you a shoutout in the changelog of our repo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…orInfo
Fixed ErrorBoundary componentStack type in @sentry/react to use React.ErrorInfo['componentStack']
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).