feat(nextjs): Give app router prefetch requests a http.server.prefetch op#13600
Merged
feat(nextjs): Give app router prefetch requests a http.server.prefetch op#13600
http.server.prefetch op#13600Conversation
Contributor
size-limit report 📦
|
Contributor
Author
|
This is a probabilistic feature because for various reasons I wasn't able to write tests for it:
Timebox overflow -> abort mission. Highly frustrating, I am done trying to get this to work. |
AbhiPrasad
reviewed
Sep 10, 2024
| */ | ||
| function isKnownPrefetchRequest(req: HTTPModuleRequestIncomingMessage): boolean { | ||
| // Currently only handles Next.js prefetch requests but may check other frameworks in the future. | ||
| return req.headers['next-router-prefetch'] === '1'; |
Contributor
There was a problem hiding this comment.
Can we look at the Sec-Purpose header instead? This should work with all header types.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Sec-Purpose
Contributor
There was a problem hiding this comment.
Oh wait it's not standardized 😭 https://chromestatus.com/feature/6247959677108224
chargome
reviewed
Sep 10, 2024
chargome
approved these changes
Sep 10, 2024
AbhiPrasad
approved these changes
Sep 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref (not complete fix) #13596
This gives Next.js prefetch requests a
http.server.prefetchop, when aNext-Router-Prefetch: 1header is present.In some situations Next.js doesn't seem to attach the header for prefetch requests. Seems like it is only attached when the current route is a dynamic route.