Merged
Conversation
This test is quite flakey -- most of the time it correctly has the image as LCP, but sometimes it will report the button as LCP. I have tried fixing it by waiting for image to load, but it did not work. I wonder if it is a bug with our LCP reporting?
AbhiPrasad
approved these changes
Aug 2, 2024
Contributor
|
just ran into this in https://github.com/getsentry/sentry-javascript/actions/runs/10221929475/job/28285584871?pr=13043, gonna merge this in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is quite flakey -- most of the time it correctly has the image as LCP, but sometimes it will report the button as LCP. I have tried fixing it by waiting for image to load, but it did not work. I wonder if it is a bug with our LCP reporting?