Conversation
| }; | ||
|
|
||
| listener(Buffer.from(JSON.stringify(data)).toString('base64')); | ||
| try { |
There was a problem hiding this comment.
I also added this to clean up logs here a bit, replay events will always fail to parse because they are compressed and not JSON.
| console.error( | ||
| '[event-proxy-server] Error: Failed to parse Sentry request envelope', | ||
| error, | ||
| proxyRequestBody, |
Check warning
Code scanning / CodeQL
Log injection
| }, | ||
| description: 'body > div#root > input#exception-button[type="button"]', | ||
| op: 'ui.interaction.click', | ||
| parent_span_id: expect.any(String), |
There was a problem hiding this comment.
shouldn't parent span be undefined for INP spans?
There was a problem hiding this comment.
should it? 😅 well today it is not! if there is an ongoing transaction, it will be a child of that. is that not correct? for me this seems like it makes sense, but 🤷 😅
There was a problem hiding this comment.
I was under the impression that INP spans were always root spans, but maybe I'm mistaken.
There was a problem hiding this comment.
cc @Lms24 when you're eventually back, you checked this out at the time. I'll merge this PR (as it shows the current behavior) but we can double check if this is fine.
While looking into #11646, I decided to add an E2E test for INP spans.