feat(nestjs): Add `@sentry/nestjs` by nicohrubec · Pull Request #12613 · getsentry/sentry-javascript

nicohrubec · 2024-06-24T11:51:46Z

Implements basic nest js package as wrapper on top of nest js

From my sample app:

andreiborza · 2024-06-25T08:52:59Z

packages/nestjs/src/sdk.ts

+/**
+ * Initializes the NestJS SDK
+ */
+export function init(options: NodeOptions | undefined = {}): void {


h: SDKs are supposed to return the Client

andreiborza · 2024-06-25T08:56:19Z

packages/nestjs/README.md

+  </a>
+</p>
+
+# Official Sentry SDK for NestJS


Suggested change

# Official Sentry SDK for NestJS

# Official Sentry SDK for NestJS (EXPERIMENTAL)

updated the readme to indicate that it is experimental

I would still put the change Andrei suggested. It's better to be very loud with it than people potentially breaking because they missed it.

Yea, the Nuxt and the Solid sdk both follow this "convention" now.

Sure, added

andreiborza · 2024-06-25T08:57:37Z

packages/nestjs/jest.config.js

@@ -0,0 +1 @@
+module.exports = require('../../jest/jest.config.js');


Hm, wondering if we shouldn't use vitest instead.
cc @mydea @lforst

Yeah I like that. @nicohrubec would you mind adding a vitest setup instead of jest. You can take inspiration from the svelte, sveltekit and solid packages.

andreiborza · 2024-06-25T09:01:33Z

packages/nestjs/yarn.lock

@@ -0,0 +1,772 @@
+# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.


m: You can remove this file, it was probably generated before you added the package to the workspace.

thanks for the hint, removed it

…into nh/nest-sdk

lforst · 2024-06-25T09:31:09Z

packages/nestjs/package.json

+  "optionalDependencies": {
+    "opentelemetry-instrumentation-fetch-node": "1.2.0"
+  },


Let's get rid of this

…into nh/nest-sdk

lforst · 2024-06-25T11:33:04Z

packages/nestjs/README.md

+# Official Sentry SDK for NestJS
+
+This SDK is considered **experimental and in an alpha state**. It may experience breaking changes. Please reach out on
+[GitHub](https://github.com/getsentry/sentry-javascript/issues/new/choose) if you have any feedback or concerns.


I think we should flesh out the readme a bit more. Ideally we get it to a similar state as the readme of the @sentry/node package with basic setup instructions and how to use. Once we add more features to this package we can update this readme again.

andreiborza

Good stuff!

dismissing because some critical things are still missing

This reverts commit 7c38b7f.

andreiborza · 2024-06-26T10:30:44Z

packages/nestjs/package.json

@@ -0,0 +1,71 @@
+{
+  "name": "@sentry/nestjs",
+  "version": "8.11.0",


This should be 8.12.0 now right?

lforst · 2024-06-26T10:37:10Z

packages/nestjs/package.json

+  "author": "Sentry",
+  "license": "MIT",
+  "engines": {
+    "node": ">=14.18"


We should align this with the minimum supported version of nest since we also don't test for 14.

nicohrubec added 10 commits June 24, 2024 13:48

Add nest js basic package

d7141cb

Fix build failure: Add missing npm config file

c470400

Update yarn lock

33d016a

Rename nest package to nestjs

c8a9c4a

Fix package name

5ad16dc

Apply biome suggested changes

201fa58

Update build paths in package json

a461de8

Maybe fix build failure

8e45888

Add nestjs to verdaccio config

075fe71

Update nest init method signature

43d53b8

nicohrubec marked this pull request as ready for review June 25, 2024 08:35

Merge branch 'develop' into nh/nest-sdk

bdfd89b

andreiborza reviewed Jun 25, 2024

View reviewed changes

nicohrubec added 3 commits June 25, 2024 11:18

Remove yarn.lock in nest package

c99d7a0

Update README

60aeb8d

Merge branch 'nh/nest-sdk' of github.com:getsentry/sentry-javascript …

aa1ecb5

…into nh/nest-sdk

lforst reviewed Jun 25, 2024

View reviewed changes

Luca Forstner and others added 5 commits June 25, 2024 09:31

undo yarn lock changes

f69273e

Fix yarn.lock

acfc125

Merge branch 'nh/nest-sdk' of github.com:getsentry/sentry-javascript …

43a3d31

…into nh/nest-sdk

Remove unnecessary optional dependency

1502aaf

Return client from nest init

86c4864

lforst changed the title ~~Add nest js basic package~~ feat(nestjs): Add @sentry/nestjs Jun 25, 2024

lforst reviewed Jun 25, 2024

View reviewed changes

nicohrubec added 3 commits June 25, 2024 13:48

Update README

bea2348

Update README

817d81e

Run tests with vitest instead of jest

dd9cd37

andreiborza previously approved these changes Jun 25, 2024

View reviewed changes

Lint

e337949

nicohrubec and others added 10 commits June 25, 2024 16:15

Update craft.yml

0b5e2fc

Try to fix ci

ac51900

Merge branch 'develop' into nh/nest-sdk

4685987

Update node-nestjs e2e test

2fe22d4

Update dependency

2928842

Rename node-nestjs e2e to nestjs

7c38b7f

Revert "Rename node-nestjs e2e to nestjs"

b42918c

This reverts commit 7c38b7f.

Exclude nest package from node 14 unit tests

957522f

Rename node-nestjs e2e to nestjs

48a3a98

Drop prepack step

6ab0565

nicohrubec requested review from andreiborza and lforst June 26, 2024 10:26

andreiborza reviewed Jun 26, 2024

View reviewed changes

andreiborza approved these changes Jun 26, 2024

View reviewed changes

lforst reviewed Jun 26, 2024

View reviewed changes

lforst approved these changes Jun 26, 2024

View reviewed changes

Address pr comments

cb21e07

nicohrubec merged commit 8c94548 into develop Jun 26, 2024

nicohrubec deleted the nh/nest-sdk branch June 26, 2024 11:09

nicohrubec mentioned this pull request Jul 4, 2024

NestJS SDK #12504

Closed

nicohrubec self-assigned this Jul 30, 2024

	# Official Sentry SDK for NestJS
	# Official Sentry SDK for NestJS (EXPERIMENTAL)

		@@ -0,0 +1 @@
		module.exports = require('../../jest/jest.config.js');

		@@ -0,0 +1,772 @@
		# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.

Uh oh!

Conversation

nicohrubec commented Jun 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andreiborza Jun 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andreiborza left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nicohrubec commented Jun 24, 2024 •

edited

Loading

andreiborza Jun 25, 2024 •

edited

Loading