ci: Add workflow to automatically add external contributors to CHANGELOG.md#12428
ci: Add workflow to automatically add external contributors to CHANGELOG.md#12428
Conversation
2934ab3 to
e0b32ad
Compare
This reverts commit b0c4a8a.
666087e to
7f4a720
Compare
| runs-on: ubuntu-20.04 | ||
| if: | | ||
| github.event_name == 'pull_request' | ||
| && (github.action == 'opened' || github.action == 'reopened') |
There was a problem hiding this comment.
do not run this on each update, as it is kind of wasteful (it should not actually error, just unnecessary computation)
Lms24
left a comment
There was a problem hiding this comment.
Looking at the example PR, shouldn't the workflow have appended the new contributor to the already mentioned one? We could also just keep a list of contributors in the ##Unreleased section to simplify the appending process
Lms24
left a comment
There was a problem hiding this comment.
Regardless, I'm fine with either way, as long as we don't by default overwrite already mentioned contributors 😅
It should! I forced it to only add a single entry to test how it looks (I manually removed it in the changelog) |
I added some logic to handle this, hopefully. It's regex-y, but I tested the different scenarios and it should work to append stuff correctly if it exsits! |
This adds a new GHA job that, if a PR is created by an external contributor, it will open a PR against that branch that adds the contributor to the changelog, so we do not forget about this.
It will open a PR like this:
#12435
which we have to manually merge/review, so nothing "bad" can happen.