fix(aws-serverless): Avoid minifying Module._resolveFilename in Lambda layer bundle#12232
Merged
fix(aws-serverless): Avoid minifying Module._resolveFilename in Lambda layer bundle#12232
Module._resolveFilename in Lambda layer bundle#12232Conversation
mydea
approved these changes
May 27, 2024
This was referenced May 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes one of the two issues that currently cause our lambda layer to break. When we build the lambda layer bundle we apply minification via our terser plugin which mangles
_-prefixed private variables - likeModule._resolveFilename.To be clear, this PR unfortunately does not fix the lambda layer as we're still blocked on this issue. Not sure what we can do SDK-side to fix this.
ref: #12089