fix(node): Ensure fetch/http breadcrumbs are created correctly#12137
Merged
fix(node): Ensure fetch/http breadcrumbs are created correctly#12137
Conversation
Contributor
size-limit report 📦
|
|
This should also be added to the |
Member
Author
Did that! And actually noticed this was fundamentally flawed, and tied to the http.client spans - so it was not working at all without performance 😬 so I adjusted all of this for fetch and http to ensure we always get breadcrumbs, and added tests for this. |
8bcf4e3 to
012ca89
Compare
3 tasks
AbhiPrasad
approved these changes
May 21, 2024
012ca89 to
a5558ec
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that (node) fetch and http requests generate breadcrumbs correctly, even if tracing is disabled.
It also adds tests for this, and ensures we pass the request/response to the hint correctly.
Fixes #12132