fix(aws-serverless): Add awslambda-auto to package.json exports#12021
Merged
fix(aws-serverless): Add awslambda-auto to package.json exports#12021
awslambda-auto to package.json exports#12021Conversation
andreiborza
reviewed
May 14, 2024
lforst
approved these changes
May 14, 2024
Comment on lines
+44
to
+48
| "./awslambda-auto": { | ||
| "import": { | ||
| "default": "./build/npm/cjs/awslambda-auto.js" | ||
| } | ||
| }, |
Contributor
There was a problem hiding this comment.
import is used for ESM but the file is CJS. I don't think this will work (or is necessary) and we can remove this block
Member
Author
There was a problem hiding this comment.
thanks - copy paste error :D
I added this block, as this is a cleaner way to declare the import (without the dist). I left dist for compatibility reasons.
Contributor
size-limit report 📦
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In v7, the exports were not explicitly defined. In v8, the
awslambda-autoexport has to be added to the list of exports (done in this PR). Also added a variant without thedist, so it can be added to theNODE_OPTIONSas-r @sentry/aws-serverless/awslambda-autofixes #12012