fix(react): Fix react router v4/v5 instrumentation#11855
Merged
Conversation
mydea
commented
Apr 30, 2024
| if (props && props.computedMatch && props.computedMatch.isExact) { | ||
| getCurrentScope().setTransactionName(props.computedMatch.path); | ||
| const route = props.computedMatch.path; | ||
| const activeRootSpan = getActiveRootSpan(); |
Member
Author
There was a problem hiding this comment.
This is the actual fix - we got the root span at instrument time, not at route-render time, leading to this not working as expected 😬
Member
There was a problem hiding this comment.
That's a tricky one! Good catch 👍🏻
3 tasks
s1gr1d
approved these changes
Apr 30, 2024
This was referenced May 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out we were not correctly setting parametrized route names for react router v4/v5 😬 We had no proper test covering this.
So I added a new E2E test
react-router-5that actually checks that parametrization etc. works as expected.Fixes #11815