Skip to content

ref: Always return an immediately generated event ID from captureException(), captureMessage(), and captureEvent()#11805

Merged
lforst merged 2 commits intodevelopfrom
lforst-dont-assume-syncpromis
Apr 26, 2024
Merged

ref: Always return an immediately generated event ID from captureException(), captureMessage(), and captureEvent()#11805
lforst merged 2 commits intodevelopfrom
lforst-dont-assume-syncpromis

Conversation

@lforst
Copy link
Copy Markdown
Contributor

@lforst lforst commented Apr 26, 2024

This is a general QoL improvement and will also allow us to remove the SyncPromise.

…eption()`, `captureMessage()`, and `captureEvent()`
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 26, 2024

size-limit report 📦

Path Size
@sentry/browser 21.64 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing) 32.68 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay) 68.03 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.43 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.07 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.28 KB (-0.01% 🔽)
@sentry/browser (incl. Feedback) 37.78 KB (-0.01% 🔽)
@sentry/browser (incl. sendFeedback) 26.43 KB (-0.01% 🔽)
@sentry/browser (incl. FeedbackAsync) 30.93 KB (0%)
@sentry/react 24.33 KB (-0.02% 🔽)
@sentry/react (incl. Tracing) 35.64 KB (-0.02% 🔽)
@sentry/vue 25.47 KB (-0.01% 🔽)
@sentry/vue (incl. Tracing) 34.47 KB (-0.02% 🔽)
@sentry/svelte 21.77 KB (-0.04% 🔽)
CDN Bundle 23.95 KB (-0.01% 🔽)
CDN Bundle (incl. Tracing) 33.98 KB (+0.02% 🔺)
CDN Bundle (incl. Tracing, Replay) 67.67 KB (+0.01% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) 83.55 KB (+0.01% 🔺)
CDN Bundle - uncompressed 70.58 KB (+0.03% 🔺)
CDN Bundle (incl. Tracing) - uncompressed 100.94 KB (+0.02% 🔺)
CDN Bundle (incl. Tracing, Replay) - uncompressed 210.55 KB (+0.01% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 256.94 KB (+0.01% 🔺)
@sentry/nextjs (client) 34.86 KB (0%)
@sentry/sveltekit (client) 33.24 KB (-0.01% 🔽)
@sentry/node 138.47 KB (-0.01% 🔽)

@lforst lforst requested review from Lms24, mydea and s1gr1d April 26, 2024 09:52
@lforst lforst marked this pull request as ready for review April 26, 2024 09:55
@lforst lforst merged commit 48995b1 into develop Apr 26, 2024
@lforst lforst deleted the lforst-dont-assume-syncpromis branch April 26, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants