feat(core): Wrap cron withMonitor callback in withIsolationScope#11797
Merged
AbhiPrasad merged 2 commits intodevelopfrom Apr 26, 2024
Merged
feat(core): Wrap cron withMonitor callback in withIsolationScope#11797AbhiPrasad merged 2 commits intodevelopfrom
withMonitor callback in withIsolationScope#11797AbhiPrasad merged 2 commits intodevelopfrom
Conversation
mydea
approved these changes
Apr 26, 2024
Member
mydea
left a comment
There was a problem hiding this comment.
this makes sense to me!
Maybe (can be in a follow up) we can add one or two tests for this, ensuring crons are properly isolated 🤔
Collaborator
Author
I was actually in the middle of writing cron tests when I got distracted by isolation! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple cron jobs can run at the same time and they may run on a server where other work is being performed.
Wrapping the
withMonitorcallback inwithIsolationScopeensures that scope and breadcrumbs for the cron tasks remain isolated.