Conversation
Lms24
approved these changes
Apr 25, 2024
Comment on lines
+49
to
+50
| // We want to avoid repeating the whole type definition here... | ||
| // eslint-disable-next-line @typescript-eslint/explicit-function-return-type |
Member
There was a problem hiding this comment.
l: We could just create a FeedbackIntegration type that extends the Integration interface instead, to avoid the eslint-disable here, no? No strong feelings though, feel free to merge as-is!
Member
Author
There was a problem hiding this comment.
you are right, this is better. I added a proper type! (had to inline it because otherwise TS complains somehow again... but it works)
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
ryan953
approved these changes
Apr 25, 2024
billyvg
approved these changes
Apr 25, 2024
s1gr1d
approved these changes
Apr 26, 2024
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this while bumping sentry itself - the types are wrong today, because we return it as
IntegrationFnwhich is just a generic integration with no custom methods.