fix(browser): Set custom sentry source correctly#11735
Merged
AbhiPrasad merged 1 commit intodevelopfrom Apr 23, 2024
Merged
Conversation
Contributor
size-limit report 📦
|
AbhiPrasad
commented
Apr 23, 2024
| if (finalStartSpanOptions.name !== finalStartSpanOptions.name) { | ||
| // If `finalStartSpanOptions.name` is different than `startSpanOptions.name` | ||
| // it is because `beforeStartSpan` set a custom name. Therefore we set the source to 'custom'. | ||
| if (startSpanOptions.name !== finalStartSpanOptions.name) { |
Contributor
Author
There was a problem hiding this comment.
This is the change. I'm not sure how the tests were passing 🤔
Member
There was a problem hiding this comment.
I guess we never tested starting a pageload/navigation txn with beforeStartSpan 🤔
Lms24
approved these changes
Apr 23, 2024
Member
Lms24
left a comment
There was a problem hiding this comment.
Great catch and also good cleanup!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primary change is to make
finalStartSpanOptions.name !== finalStartSpanOptions.name->startSpanOptions.name !== finalStartSpanOptions.nameinpackages/browser/src/tracing/browserTracingIntegration.ts.While I was here though I cleaned up some other code to improve bundle size. Let me know if you want me to extract the cleanup changes, I figured it's all easier to review here with the same context.