fix(angular): call showReportDialog in root context#11703
Merged
Lms24 merged 1 commit intogetsentry:developfrom Apr 25, 2024
Merged
fix(angular): call showReportDialog in root context#11703Lms24 merged 1 commit intogetsentry:developfrom
showReportDialog in root context#11703Lms24 merged 1 commit intogetsentry:developfrom
Conversation
e3c1594 to
34a62e3
Compare
AbhiPrasad
reviewed
Apr 22, 2024
packages/angular/.eslintrc.cjs
Outdated
| }, | ||
| extends: ['../../.eslintrc.js'], | ||
| rules: { | ||
| '@sentry-internal/sdk/no-optional-chaining': 'off', |
Contributor
There was a problem hiding this comment.
we do not want to turn this off - see https://blog.sentry.io/performance-impact-of-generated-javascript/#removing-optional-chaining
Lms24
reviewed
Apr 22, 2024
packages/angular/src/zone.ts
Outdated
| // available in the `<root>` context. | ||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access | ||
| const isNgZoneEnabled = typeof Zone !== 'undefined' && !!Zone.current; | ||
| const isNgZoneEnabled = typeof Zone !== 'undefined' && !!Zone.root?.run; |
Member
There was a problem hiding this comment.
!!Zone.root?.run is this function also available in older Angular versions? We need to stay compatible with Angular 14+
34a62e3 to
ac3ab8b
Compare
This commit calls `showReportDialog` outside of the Angular context to prevent unnecessary view updates when asynchronous tasks are set up within the `showReportDialog` function.
ac3ab8b to
b05462a
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit calls
showReportDialogoutside of the Angular context to preventunnecessary view updates when asynchronous tasks are set up within the
showReportDialogfunction.