ref(browser): Streamline pageload span creation and scope handling#11679
Merged
ref(browser): Streamline pageload span creation and scope handling#11679
Conversation
Lms24
commented
Apr 18, 2024
| }); | ||
| }); | ||
|
|
||
| it("saves the span's negative sampling decision and its DSC on the propagationContext when the span finishes", () => { |
Member
Author
There was a problem hiding this comment.
just thought I'd throw in a semi-related test that was previously missing
mydea
approved these changes
Apr 18, 2024
Contributor
size-limit report 📦
|
lforst
approved these changes
Apr 18, 2024
Contributor
lforst
left a comment
There was a problem hiding this comment.
Very nice, thank you! Much cleaner 😌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed with @lforst yesterday, we can streamline our pageload span creation logic now that we actually want to keep the propagation context on the scope after the transaction finished (see #11599). Previously, we'd fork a new scope for the pageload span but IMHO (and according to all our tests) this is no longer necessary.
ref #11599