test(browser-integration-tests): Check trace envelope headers in trace lifetime tests#11660
Merged
test(browser-integration-tests): Check trace envelope headers in trace lifetime tests#11660
trace envelope headers in trace lifetime tests#11660Conversation
ffddf37 to
cdfab9d
Compare
AbhiPrasad
approved these changes
Apr 17, 2024
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds checks for the contents of the
traceenvelope headers in our newtrace-lifetimetest suite. The purpose of these checks is to ensure that we not only propagate and send correct trace data in request headers and Sentry events (trace context) but also in thetraceenvelope header.Side note: This makes the tests notably longer but IMO its worth to have deep checks here because we can ensure that we always send the right data everywhere. Also, I had to write a "new" request parser to get both, events and the envelope headers.
ref #11599