feat(node): Add connect instrumentation#11651
Merged
Conversation
647ef2d to
212269b
Compare
Contributor
size-limit report 📦
|
lforst
approved these changes
Apr 17, 2024
Contributor
lforst
left a comment
There was a problem hiding this comment.
Thank you Onur! Looks great.
| @@ -0,0 +1,10 @@ | |||
| { | |||
| "compilerOptions": { | |||
Contributor
There was a problem hiding this comment.
Since we are only typescript to run the app with ts-node and to check types we can probably configure this to not emit any files and then we can also get rid of the gitignore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #11405
Adds OTEL-powered auto instrumentation for
connectmiddleware.This instrumentation should be used together with the
httpinstrumentationAs it's a middleware library, the scope of this instrumentation is limited. In summary:
connect. They should be handled by thehttpinstrumentation.httpserver.