fix(browser): Don't assume window.document is available#11602
Merged
fix(browser): Don't assume window.document is available#11602
Conversation
Contributor
size-limit report 📦
|
Lms24
approved these changes
Apr 15, 2024
Member
Lms24
left a comment
There was a problem hiding this comment.
Good catch! Is there an issue where this came up?
| // Wrap in a setTimeout so the callback is run in a separate task | ||
| // to avoid extending the keyboard/click handler to reduce INP impact | ||
| // https://github.com/GoogleChrome/web-vitals/issues/383 | ||
| WINDOW.document.addEventListener(type, () => setTimeout(stopListening, 0), true); |
Member
There was a problem hiding this comment.
l: for bundle size reasons: Is it necessary to explicitly call addEventListener on WINDOW.document if we have the guard above?
Contributor
Author
Yeah this one! #5289 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #5289 (comment)
We cannot assume window.document is available because we support web workers.