feat(opentelemetry): Update OTEL packages & relax some version ranges#11580
Merged
AbhiPrasad merged 1 commit intodevelopfrom Apr 16, 2024
Merged
feat(opentelemetry): Update OTEL packages & relax some version ranges#11580AbhiPrasad merged 1 commit intodevelopfrom
AbhiPrasad merged 1 commit intodevelopfrom
Conversation
AbhiPrasad
approved these changes
Apr 12, 2024
Contributor
size-limit report 📦
|
Lms24
approved these changes
Apr 12, 2024
1a8426a to
2c9b95f
Compare
Also relaxe the ranges for `@sentry/node` to not require strict dependencies for the core packages. For instrumentation, we continue to have stricter dependencies.
99ea303 to
69619f0
Compare
Contributor
|
Going to merge this in to remove some merge conflicts with my upcoming otel related PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps all our OTEL dependencies to require the most up to date versions as of today for all the core packages.
This allows us to use the new semantic attributes, which esp. also some instrumentation uses in newer versions. By requiring this as a minimum version, we can ensure that we can update all our instrumentation.
This also relaxes all of the core packages to
^range, so users can easier use@sentry/nodetogether with their own otel instrumentation. The instrumentation we add remains hard-pinned.To avoid deprecation warnings I updated all the semantic attributes usage to the new syntax.