Skip to content

fix(spans): Allow zero exclusive time for INP spans#11408

Merged
edwardgou-sentry merged 2 commits intov7from
egou/fix/allow-zero-exclusive-time-for-spans
Apr 3, 2024
Merged

fix(spans): Allow zero exclusive time for INP spans#11408
edwardgou-sentry merged 2 commits intov7from
egou/fix/allow-zero-exclusive-time-for-spans

Conversation

@edwardgou-sentry
Copy link
Copy Markdown
Contributor

@edwardgou-sentry edwardgou-sentry commented Apr 3, 2024

Allows exclusive time for spans to be 0, including inp spans.

AbhiPrasad
AbhiPrasad reviewed Apr 3, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a test for this!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 80.53 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 71.52 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 75.54 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 65.15 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 35.45 KB (+0.13% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 35.33 KB (+0.12% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.52 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.53 KB (0%)
@sentry/browser - Webpack (gzipped) 22.74 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 78.64 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 70.01 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 35.8 KB (+0.08% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 25.17 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 220.41 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 108.22 KB (+0.1% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 75.48 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 39.02 KB (+0.08% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 72.01 KB (+0.06% 🔺)
@sentry/react - Webpack (gzipped) 22.77 KB (+0.01% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 89.85 KB (+0.04% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 53.98 KB (+0.06% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.3 KB (0%)

@AbhiPrasad AbhiPrasad mentioned this pull request Apr 3, 2024
Closed
@edwardgou-sentry edwardgou-sentry merged commit 9bfadb5 into v7 Apr 3, 2024
@edwardgou-sentry edwardgou-sentry deleted the egou/fix/allow-zero-exclusive-time-for-spans branch April 3, 2024 19:13
@Lms24 Lms24 mentioned this pull request Apr 10, 2024
Merged
@Lms24 Lms24 mentioned this pull request May 31, 2024
Merged
@data-sync-user data-sync-user mentioned this pull request Jun 3, 2024
Closed
This was referenced Jun 4, 2024
Merged
Merged
@Lms24 Lms24 mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edwardgou-sentry @AbhiPrasad