test(node): Use different test server ports for node and node-experimental packages#11116
Merged
test(node): Use different test server ports for node and node-experimental packages#11116
node and node-experimental packages#11116Conversation
…rimental` packages
mydea
approved these changes
Mar 15, 2024
Member
mydea
left a comment
There was a problem hiding this comment.
LGTM, can we maybe randomize them, I wonder? Or let them pick a free one...
Contributor
Author
Absolutely, just wanted to fix this pragmatically because it is annoying as hell. |
Contributor
Author
|
First try succeeded. I am merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fingers crossed.
Fixes #11111
Node and node-experimental used the same port to set up a test-server. I believe it may have flaked depending on whether the tests were ran at the same time or not.