Skip to content

fix(types): Remove usage of allowSyntheticDefaultImports#11073

Merged
AbhiPrasad merged 3 commits intodevelopfrom
timfish/remove-allowSyntheticDefaultImports
Mar 13, 2024
Merged

fix(types): Remove usage of allowSyntheticDefaultImports#11073
AbhiPrasad merged 3 commits intodevelopfrom
timfish/remove-allowSyntheticDefaultImports

Conversation

@timfish
Copy link
Copy Markdown
Collaborator

@timfish timfish commented Mar 13, 2024

The TypeScript docs say

allowSyntheticDefaultImports without esModuleInterop should be avoided. It changes the compiler’s checking behavior without changing the code emitted by tsc, allowing potentially unsafe JavaScript to be emitted. Additionally, the checking changes it introduces are an incomplete version of the ones introduced by esModuleInterop.

@timfish timfish force-pushed the timfish/remove-allowSyntheticDefaultImports branch from f1403a9 to 6a1c3e9 Compare March 13, 2024 09:28
@AbhiPrasad AbhiPrasad merged commit 39360d9 into develop Mar 13, 2024
@AbhiPrasad AbhiPrasad deleted the timfish/remove-allowSyntheticDefaultImports branch March 13, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants