ref: Remove deprecated properties from startSpan options#11054
Merged
ref: Remove deprecated properties from startSpan options#11054
startSpan options#11054Conversation
lforst
reviewed
Mar 12, 2024
| { | ||
| op: 'function.nextjs', | ||
| name: `${componentType}.${generationFunctionIdentifier} (${componentRoute})`, | ||
| data, |
Contributor
There was a problem hiding this comment.
This looked sus but I saw that we also set it as extra on the scope.
Member
Author
There was a problem hiding this comment.
jup, that's why I removed it, this should remain the same on the event as far as I can tell! (it is also not flat so cannot be attributes directly, we'd need to flatten this but I don't think that's worth it here)
lforst
approved these changes
Mar 12, 2024
0a5ed80 to
308a8e1
Compare
Lms24
reviewed
Mar 12, 2024
|
|
||
| /** Attributes for the span. */ | ||
| attributes?: SpanAttributes; | ||
|
|
Member
There was a problem hiding this comment.
l/m: Is there a reason for not yet removing origin? It's also deprecated.
Member
There was a problem hiding this comment.
btw totally fine if you wanna tackle this in a follow-up PR; Just noticed it
Member
Author
There was a problem hiding this comment.
Yeah I'll do that in a follow up I think as we have more usages of this I believe! :)
308a8e1 to
a43374a
Compare
Lms24
approved these changes
Mar 12, 2024
So the public API for this is now fully aligned!
also remove unneeded stuff
a43374a to
ce8d08b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So the public API for this is now fully aligned!
In nextjs, I moved places where we passed
requestas metadata to put this on the isolation scope (in some places we already did that anyhow).