feat(core): Decouple scope.transactionName from root spans#10991
Merged
feat(core): Decouple scope.transactionName from root spans#10991
scope.transactionName from root spans#10991Conversation
Contributor
size-limit report 📦
|
mydea
reviewed
Mar 11, 2024
| /** | ||
| * Transaction Name | ||
| * | ||
| * IMPORTANT: The transaction name on the scope has nothing to do with root spans/transaction objects. |
mydea
approved these changes
Mar 11, 2024
Member
mydea
left a comment
There was a problem hiding this comment.
nice! left some small nits but overall looks good to me 👍
45b7d13 to
81e048b
Compare
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes some changes to how we apply scope data to events. Previously, we used to apply the transaction name
scopeData.transactionNameto the
event.transactionfield.With our efforts to decouple the scope's
transactionfield from a currently active transaction/root span, we now change this behaviour so that:event.transactionfromscopeData.transactionName(e.g. errors, profiles, replay)event.transactionfrom the root span nameFurthermore, this PR also undeprecates
ScopeData.transactionNameas we'll still need it.ref #10846