feat: Set required node version to >=14.18.0 for all packages#10968
Merged
AbhiPrasad merged 2 commits intodevelopfrom Mar 7, 2024
Merged
feat: Set required node version to >=14.18.0 for all packages#10968AbhiPrasad merged 2 commits intodevelopfrom
AbhiPrasad merged 2 commits intodevelopfrom
Conversation
mydea
approved these changes
Mar 7, 2024
Contributor
size-limit report 📦
|
timfish
approved these changes
Mar 7, 2024
Collaborator
timfish
left a comment
There was a problem hiding this comment.
For posterity this makes the minimum supported Electron version v15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we would like to start using node protocol imports in the SDK to unblock #10960 and #10928
This requires us to have a minimum supported Node version of
14.18.0as per https://2ality.com/2021/12/node-protocol-imports.html