feat(core): Ensure trace APIs always return a span#10942
Merged
AbhiPrasad merged 3 commits intodevelopfrom Mar 6, 2024
Merged
Conversation
Contributor
size-limit report 📦
|
When tracing is disabled or otherwise skipped, they return a non recording span instead of undefined.
1cc9bbc to
412dd69
Compare
AbhiPrasad
approved these changes
Mar 6, 2024
Contributor
|
I'm gonna merge this in because I need it for a change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When tracing is disabled or otherwise skipped, they return a non recording span instead of undefined.
This aligns the
startSpan,startSpanManualandstartInactiveSpanAPIs with opentelemetry, where you also always get a span back.Especially, this makes our APIs much nicer to use, as you don't need to guard for span existence everywhere anymore 🎉
I tried to update all tests etc. to use this and remove some unnecessary check (side note: I wonder if we could add an eslint rule: https://typescript-eslint.io/rules/no-unnecessary-condition/) I'll look into maybe adding this rule as well.