feat(esm): Import rather than require inspector#10910
Merged
AbhiPrasad merged 1 commit intodevelopfrom Mar 4, 2024
Merged
Conversation
AbhiPrasad
approved these changes
Mar 4, 2024
Contributor
|
Gonna merge this in because I wanna test something out with serverless |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does break support for custom builds of Node which have been built without inspector support. The only one that comes to mind is Vercel/pkg but this has recently been deprecated since Node v21 supports building single file executables.
We may come back later and find a way to work around this but we cannot use async
importwith the current code, so we'll need to revisit this after we have a proper ESM build working!This also removes
local-variables-async.tssince it's not used and async inspector requires a worker thread to work.