ref(astro): Put request as SDK processing metadata instead of span data#10840
ref(astro): Put request as SDK processing metadata instead of span data#10840
Conversation
Lms24
left a comment
There was a problem hiding this comment.
Can we add a small entry for this in the migration guide? (the trackHeaders field was requested by two users so I know someone is using it 😅)
|
I added a migration entry for this! While doing this, I noticed we should also revisit the defaults for request data integration - there we capture all of this by default 🤔 Also, maybe we can/should remove the custom |
5281b42 to
6a37477
Compare
6a37477 to
e513fb4
Compare
Lms24
left a comment
There was a problem hiding this comment.
Thanks!
Also, maybe we can/should remove the custom ip address stuff from astro middleware as well in favor of letting the request data integration do this?
I have too little context on the request data integration - does it already do this? If yes, let's do it but I don't know if picking up the ip adress from the context passed into the astro middleware works with the integration. We might need to adjust that.
|
I'll leave the IP address stuff for a follow up! IP addresses are disabled by default in request data, so that needs opt in even today. |
This removes usage of deprecated options to
startSpan, and removes thetrackHeadersoption to the astro middleware in favor of using the general request data integration that should pick this up if put on the scope as SDK processing metadata.