Skip to content

Ryan953/feedback async#10683

Merged
ryan953 merged 35 commits intocl/screenshot-integrationfrom
ryan953/feedback-async
Feb 29, 2024
Merged

Ryan953/feedback async#10683
ryan953 merged 35 commits intocl/screenshot-integrationfrom
ryan953/feedback-async

Conversation

@ryan953
Copy link
Copy Markdown
Member

@ryan953 ryan953 commented Feb 15, 2024 •
edited
Loading

This is building off a version of #10590, specifically working towards async loading of the Dialog component, and rewriting it in preact in order to host and interact with the screenshot feature in an easier way.

Setup in my test app is (gives screenshots):

import { feedback2Integration, feedback2ModalIntegration, feedback2ScreenshotIntegration } from "@sentry-internal/feedback2";


  integrations: [
    feedback2Integration({
      colorScheme: 'light',
      isNameRequired: false,
      isEmailRequired: false,
    }),
    feedback2ModalIntegration(),
    feedback2ScreenshotIntegration(),
  ]

@ryan953 ryan953 changed the base branch from develop to cl/screenshot-integration February 16, 2024 17:27
ryan953 added 17 commits February 17, 2024 21:28
@ryan953
rewrite Dialog and Form to use preact
f4e75a1
@ryan953
Move svg's into components/
7fc2ed1
@ryan953
remove createElement and make Actor and SuccessMessage manually
f0b9552
@ryan953
cleanup Dialog and Form callbacks
982dcdc
@ryan953
make rollup configs look similar
f5cd8e6
@ryan953
split things again so screen shots can be loaded separatly
caa2ed1
@ryan953
combine onClosed and onCancel form callbacks
dfc3eeb
@ryan953
replace isDialogOpen with a call to checkIsOpen
3bd5ddc
@ryan953
inline _handleFeedbackSubmit and handleFeedbackSubmit and simplify re…
b19e7c8 
…turn types
@ryan953
comment out console.logs for now, want to make this file happy
93af901
@ryan953
async load the SuccessMessage
90c7301
@ryan953
async load the Dialog.css module
7d6adc6
@ryan953
set sentryFeedbackColorscheme when we create the host
7901d32
@ryan953
bootstrap new feedback integration system
7650483
@ryan953
all the feedback2 stuff
bcaa805
@ryan953
the refactor into 3 integrations
e87a9e7
@ryan953
wip
ae4e49f
@ryan953 ryan953 force-pushed the ryan953/feedback-async branch from cc3c2ce to ae4e49f Compare February 23, 2024 20:08
@ryan953 ryan953 force-pushed the ryan953/feedback-async branch 4 times, most recently from 85eb75c to a181339 Compare February 24, 2024 01:09
@ryan953 ryan953 force-pushed the ryan953/feedback-async branch from a181339 to dbcbfba Compare February 24, 2024 01:19
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 26, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 84.03 KB (+8.75% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.03 KB (+0.72% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.96 KB (+0.71% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.54 KB (+0.8% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.25 KB (+1.62% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.14 KB (+1.3% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 37.34 KB (+20.79% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 37.33 KB (+20.75% 🔺)
@sentry/browser - Webpack (gzipped) 22.41 KB (+0.99% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 82.05 KB (+8.32% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.52 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.48 KB (+0.58% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.69 KB (-0.15% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.25 KB (+0.47% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 100.97 KB (+0.98% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.87 KB (+0.13% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.78 KB (+1.17% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.33 KB (+0.75% 🔺)
@sentry/react - Webpack (gzipped) 22.44 KB (+0.99% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.81 KB (+1.84% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.05 KB (+0.79% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 23.47 KB (+36.94% 🔺)

@ryan953 ryan953 requested review from billyvg and c298lee February 27, 2024 22:41
@ryan953 ryan953 marked this pull request as ready for review February 29, 2024 00:06
mydea
mydea reviewed Feb 29, 2024
View reviewed changes
c298lee
c298lee reviewed Feb 29, 2024
View reviewed changes
c298lee
c298lee reviewed Feb 29, 2024
View reviewed changes
packages/feedback2/src/modal/components/Form.tsx Outdated
class="btn btn--default"
type="button"
onClick={() => {
setIncludeScreeshot(prev => !prev);
Copy link
Copy Markdown
Contributor

@c298lee c298lee Feb 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work properly when you press cancel on the prompt to allow it to see the tab?

Copy link
Copy Markdown
Member Author

@ryan953 ryan953 Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question, and no it doesn't!

Copy link
Copy Markdown
Contributor

@c298lee c298lee Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

@ryan953 ryan953 Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handled it!

it's just passing the message along to the user, which won't always be the best. In the future we can get inside that takeScreenshot().catch(...) call and rewrite messages as needed.

SCR-20240229-jgwc

@ryan953 ryan953 force-pushed the ryan953/feedback-async branch from dfa26b9 to a4d23cd Compare February 29, 2024 15:56
@ryan953 ryan953 merged commit ea96f76 into cl/screenshot-integration Feb 29, 2024
@ryan953 ryan953 deleted the ryan953/feedback-async branch February 29, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mydea mydea mydea left review comments

@billyvg billyvg Awaiting requested review from billyvg

+1 more reviewer

@c298lee c298lee c298lee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ryan953 @mydea @c298lee