fix(publish): Ensure @sentry/hub is published in v7#10661
Merged
Conversation
mydea
reviewed
Feb 14, 2024
7d438a1 to
ce5163d
Compare
mydea
approved these changes
Feb 14, 2024
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we deleted
@sentry/hubin #10530, we also removed the craft NPM target for the hub package. Given that the craft config is always taken fromdevelop(generally, the default branch of the repository), Craft no longer published@sentry/hubwhen we cut a release from ourv7branch.Unfortunately, the NPM target does not support an optional
onlyIfPresentconfiguration, meaning for now, we have to continue publishing a@sentry/hubplaceholder package when we cut a release fromdevelop(i.e. our v8 branch at the moment).I'll spend some time trying to adjust our publishing/craft process to finally unblock us here. We shouldn't have to continue publishing a placeholder just to ensure we can publish v7 correctly.