ref: Make scope setters on hub only write to isolation scope#10572
Merged
ref: Make scope setters on hub only write to isolation scope#10572
Conversation
Contributor
size-limit report 📦
|
added 4 commits
February 8, 2024 15:36
Lms24
approved these changes
Feb 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the global
setX()functions only write to the isolation scope. Previously they wrote to both, the current scope, and the isolation scope, in the future we want these methods to only write to the isolation scope. Up until now this would have been breaking behaviour but now we can go through with it.