fix(v8/utils): Stack parser skip frames (not lines of stack string)#10560
Merged
krystofwoldrich merged 6 commits intodevelopfrom Mar 6, 2024
Merged
fix(v8/utils): Stack parser skip frames (not lines of stack string)#10560krystofwoldrich merged 6 commits intodevelopfrom
krystofwoldrich merged 6 commits intodevelopfrom
Conversation
Contributor
size-limit report 📦
|
AbhiPrasad
reviewed
Feb 9, 2024
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
Let's add a note to MIGRATION.md and we can merge this in!
timfish
approved these changes
Feb 12, 2024
Collaborator
timfish
left a comment
There was a problem hiding this comment.
Looks good. My only minor concern is that this modifies the test case to pass and these tests have been around for a long time. But if they were wrong, they were wrong!
Contributor
Author
|
@AbhiPrasad I've added the migration information, let me know if it's understandable, or if I should include an example. |
AbhiPrasad
approved these changes
Feb 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
error.framesToPop#9656In happy scenarios, the
framesToPopshould not make a difference as the Sentry backend will marknonInAppframes and hide them by default from the user.In other scenarios, when source maps are missing for example, the frames will be visible and shown as the root of an error which is misleading and confusing to our users.
Before this PR
We used
framesToPopfor two unrelated purposes.After this PR
We have two variables each having one purpose.
skipFirstLinesto skip potentially dangerous lines that could be parsed as frames but aren't frames.framesToPopto remove parsed frames.Notes
This is especially useful for React applications as the framework internally uses the
framesToPopproperty. And also for our own SDK.