ref(nextjs): Remove all deprecated API#10549
Merged
Conversation
Contributor
size-limit report 📦
|
mydea
reviewed
Feb 7, 2024
mydea
reviewed
Feb 7, 2024
| startTransactionOnLocationChange: boolean = true, | ||
| shouldInstrumentPageload: boolean, | ||
| shouldInstrumentNavigation: boolean, | ||
| startPageloadSpanCallback: StartSpanCb, |
Member
There was a problem hiding this comment.
l: We can refactor this later, but IMHO we can simplify this by just passing the client in here and directly calling the start span methods from core here?
Contributor
Author
There was a problem hiding this comment.
I don't follow ^^ Do you mind elaborating? Or do you have examples where we do something similar?
mydea
reviewed
Feb 7, 2024
packages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated
Show resolved
Hide resolved
mydea
reviewed
Feb 7, 2024
packages/nextjs/src/client/routing/pagesRouterRoutingInstrumentation.ts
Outdated
Show resolved
Hide resolved
mydea
reviewed
Feb 7, 2024
| { | ||
| sentryTrace: sentryTraceHeader ?? headers?.get('sentry-trace') ?? undefined, | ||
| baggage: baggageHeader ?? headers?.get('baggage'), | ||
| sentryTrace: headers?.get('sentry-trace') ?? undefined, |
Member
There was a problem hiding this comment.
is this not the same as leaving the ?? undefined away here? (or is it bad if this returns null, not sure if this is possible) - just because we don't do it below :)
Contributor
Author
There was a problem hiding this comment.
It's a bit ridiculous but continueTrace doesn't take null as sentryTrace value so we need to turn it into undefined. I wanted to change that anyhow. I'll clean this up in a follow-up.
Contributor
Author
|
@mydea I am blocked to migrate |
AbhiPrasad
approved these changes
Feb 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes all deprecated code from the Next.js package.