Skip to content

build(ci): Bump action dependencies for node profiling#10473

Merged
mydea merged 2 commits intodevelopfrom
fn/bump-node-profiling-actions
Feb 6, 2024
Merged

build(ci): Bump action dependencies for node profiling#10473
mydea merged 2 commits intodevelopfrom
fn/bump-node-profiling-actions

Conversation

@mydea
Copy link
Copy Markdown
Member

@mydea mydea commented Feb 2, 2024

Noticed warnings in GH for these, so bumping all of these to latest.

@mydea
build(ci): Bump action dependencies for node profiling
48bbaf6 
Noticed warnings in GH for these, so bumping all of these to latest.
@mydea mydea requested a review from JonasBa February 2, 2024 10:47
@mydea mydea self-assigned this Feb 2, 2024
mydea
mydea commented Feb 2, 2024
View reviewed changes
.github/workflows/build.yml Outdated
node-version: 20
- uses: actions/setup-python@v5
with:
python-version: '3.8.10'
Copy link
Copy Markdown
Member Author

@mydea mydea Feb 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it complains here, but I guess it would make sense to pin some version here? Thoughs on this (and which version that should be 😅 ) @JonasBa

Copy link
Copy Markdown
Member

@JonasBa JonasBa Feb 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mydea we can try LTS, but afaik devutils were removed in a minor python version, breaking node-gyp so we may need to reinstall some extra dependencies to be able to build the binaries.

Copy link
Copy Markdown
Member

@JonasBa JonasBa Feb 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick search, this is the issue I was talking about... Seems like 3.11 would be fine, so lets go with that

Copy link
Copy Markdown

@cclauss cclauss Feb 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue that you are quoting is closed because it fixed was by vendoring in packaging. nodejs/node-gyp#2869 (comment)

@cclauss
Copy link
Copy Markdown

cclauss commented Feb 2, 2024 •
edited
Loading

Dependabot should automatically create PRs to perform these upgrades but perhaps monthly is too long between updates.

sentry-javascript/.github/dependabot.yml

Line 3 in 3b2b18c

- package-ecosystem: 'github-actions'

https://github.com/getsentry/sentry-javascript/pulls?q=is%3Apr+author%3Aapp%2Fdependabot+label%3Agithub_actions

@mydea
Copy link
Copy Markdown
Member Author

mydea commented Feb 5, 2024

Dependabot should automatically create PRs to perform these upgrades but perhaps monthly is too long between updates.

sentry-javascript/.github/dependabot.yml

Line 3 in 3b2b18c

- package-ecosystem: 'github-actions'

https://github.com/getsentry/sentry-javascript/pulls?q=is%3Apr+author%3Aapp%2Fdependabot+label%3Agithub_actions

Yes, this was merged right after dependabot ran 😅 sadly all the warnings for the deprecated node16 are kind of annoying in the GH UI :(

mydea
mydea commented Feb 5, 2024
View reviewed changes
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 5, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 78.2 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.43 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.36 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 63.04 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.38 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.25 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.33 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.34 KB (0%)
@sentry/browser - Webpack (gzipped) 22.6 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.17 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.72 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.5 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.66 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 213.68 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.49 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 74.01 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.63 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.8 KB (0%)
@sentry/react - Webpack (gzipped) 22.63 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.42 KB (+1% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 51.57 KB (+1.52% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.21 KB (0%)

@mydea
Copy link
Copy Markdown
Member Author

mydea commented Feb 5, 2024

I pinned python to 3.11.7, now tests seem to pass and warnings (for this) seem to be resolved!

@mydea mydea merged commit 1a4b6e6 into develop Feb 6, 2024
@mydea mydea deleted the fn/bump-node-profiling-actions branch February 6, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@cclauss cclauss cclauss left review comments

@JonasBa JonasBa JonasBa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mydea mydea

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mydea @cclauss @JonasBa