Skip to content

test: Make some replay tests less flaky#10418

Merged
mydea merged 2 commits intodevelopfrom
fn/flaky-tests
Jan 31, 2024
Merged

test: Make some replay tests less flaky#10418
mydea merged 2 commits intodevelopfrom
fn/flaky-tests

Conversation

@mydea
Copy link
Copy Markdown
Member

@mydea mydea commented Jan 30, 2024 •
edited
Loading

This changes the replay fetch/xhr tests to not wait for the initial replay, but wait for any replay being captured, and collect snapshots as we go. This way, we may be a bit more resilient for small timing issues - hopefully...

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 30, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 78.18 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.39 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.28 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 63.01 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.41 KB (+0.03% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.28 KB (+0.05% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.33 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.34 KB (0%)
@sentry/browser - Webpack (gzipped) 22.6 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.54 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.45 KB (+0.13% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.66 KB (+0.14% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 213.12 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.13 KB (+0.14% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 74 KB (+0.16% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.56 KB (+0.11% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.78 KB (-0.02% 🔽)
@sentry/react - Webpack (gzipped) 22.63 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.45 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.76 KB (+0.01% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.21 KB (0%)

@mydea mydea requested review from Lms24 and billyvg January 30, 2024 15:30
@mydea mydea self-assigned this Jan 30, 2024
Lms24
Lms24 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@mydea
Copy link
Copy Markdown
Member Author

mydea commented Jan 30, 2024

When in the PR to fix some flakes, some other tests flake 🤯

replay/extendNetworkBreadcrumbs/fetch/captureResponseBody/test.ts:11:11 › captures text response body

@mydea mydea marked this pull request as ready for review January 30, 2024 16:47
@mydea mydea merged commit 34f9cc7 into develop Jan 31, 2024
@mydea mydea deleted the fn/flaky-tests branch January 31, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

@billyvg billyvg Awaiting requested review from billyvg

+1 more reviewer

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mydea mydea

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mydea @Lms24 @AbhiPrasad